Merge pull request #4265 from thinkyhead/rc_buzzer_patchup
Two strategies to address a stuck buzzer
This commit is contained in:
commit
6121c9018a
@ -46,7 +46,7 @@ class Buzzer {
|
||||
private:
|
||||
struct state_t {
|
||||
tone_t tone;
|
||||
uint32_t timestamp;
|
||||
uint32_t endtime;
|
||||
} state;
|
||||
|
||||
protected:
|
||||
@ -82,7 +82,7 @@ class Buzzer {
|
||||
*/
|
||||
void reset() {
|
||||
this->off();
|
||||
this->state.timestamp = 0;
|
||||
this->state.endtime = 0;
|
||||
}
|
||||
|
||||
public:
|
||||
@ -117,14 +117,14 @@ class Buzzer {
|
||||
* playing the tones in the queue.
|
||||
*/
|
||||
virtual void tick() {
|
||||
if (!this->state.timestamp) {
|
||||
if (!this->state.endtime) {
|
||||
if (this->buffer.isEmpty()) return;
|
||||
|
||||
this->state.tone = this->buffer.dequeue();
|
||||
this->state.timestamp = millis() + this->state.tone.duration;
|
||||
this->state.endtime = millis() + this->state.tone.duration;
|
||||
if (this->state.tone.frequency > 0) this->on();
|
||||
}
|
||||
else if (millis() >= this->state.timestamp) this->reset();
|
||||
else if (ELAPSED(millis(), this->state.endtime)) this->reset();
|
||||
}
|
||||
};
|
||||
|
||||
|
@ -2334,12 +2334,14 @@ void kill_screen(const char* lcd_msg) {
|
||||
lcdDrawUpdate = LCDVIEW_CLEAR_CALL_REDRAW;
|
||||
next_button_update_ms = millis() + 500;
|
||||
|
||||
// Buzz and wait. The delay is needed for buttons to settle!
|
||||
#if ENABLED(LCD_USE_I2C_BUZZER)
|
||||
lcd.buzz(LCD_FEEDBACK_FREQUENCY_DURATION_MS, LCD_FEEDBACK_FREQUENCY_HZ);
|
||||
delay(10);
|
||||
#elif PIN_EXISTS(BEEPER)
|
||||
buzzer.tone(LCD_FEEDBACK_FREQUENCY_DURATION_MS, LCD_FEEDBACK_FREQUENCY_HZ);
|
||||
for (int8_t i = 5; i--;) { buzzer.tick(); delay(2); }
|
||||
#endif
|
||||
delay(10); // needed for buttons to settle
|
||||
}
|
||||
|
||||
/**
|
||||
|
Loading…
Reference in New Issue
Block a user