Apply Ruff's flake8-type-checking (TCH) rules

doorcontrol/views.py

@@ -1,8 +1,8 @@
 import datetime
+from typing import TYPE_CHECKING
 
 from django.contrib.auth.mixins import PermissionRequiredMixin
 from django.core.exceptions import BadRequest
-from django.core.paginator import Page
 from django.db.models import Count, F, FloatField, Q, Window
 from django.db.models.functions import Lead, Trunc
 from django.urls import path, reverse_lazy
@@ -27,6 +27,9 @@ from .tables import (
     UnitTimeTable,
 )
 
+if TYPE_CHECKING:
+    from django.core.paginator import Page
+
 REPORTS = []
 
 

membershipworks/models.py

@@ -1,6 +1,5 @@
 import uuid
 from datetime import datetime, timedelta
-from decimal import Decimal
 from typing import TYPE_CHECKING, TypedDict
 
 import django.core.mail.message
@@ -596,6 +595,7 @@ class EventExt(Event):
 
 
 if TYPE_CHECKING:
+    from decimal import Decimal
 
     class EventExtAnnotations(TypedDict):
         meetings: int

paperwork/views.py

@@ -1,4 +1,4 @@
-from collections.abc import Iterable
+from typing import TYPE_CHECKING
 
 from django.conf import settings
 from django.contrib.auth.decorators import login_required
@@ -44,6 +44,9 @@ from .tables import (
     WaiverReportTable,
 )
 
+if TYPE_CHECKING:
+    from collections.abc import Iterable
+
 WIKI_URL = settings.WIKI_URL
 
 

pyproject.toml

@@ -80,6 +80,7 @@ select = [
   "PIE",
   "LOG",
   "RSE",
+  "TCH",
 ]
 ignore = ["ISC001"]
 

reservations/models.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
-from collections.abc import Iterable
-from datetime import datetime
+from typing import TYPE_CHECKING
 
 from django.contrib.auth import get_user_model
 from django.db import models
@@ -10,6 +9,10 @@ from django.utils import timezone
 
 from model_utils.managers import InheritanceQuerySetMixin
 
+if TYPE_CHECKING:
+    from collections.abc import Iterable
+    from datetime import datetime
+
 
 class Resource(models.Model):
     name = models.CharField(max_length=256)