CMS/memberPlumbing
Archived
2
0
Fork 1
Code Issues 8 Pull Requests 2 Releases Wiki Activity

DoorController: Check for HTTP error before trying to parse XML

Browse Source
This commit is contained in:
Adam Goldsmith 2020-06-02 22:28:34 -04:00
parent ab6d0bdbc4
commit 2855e773cd
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
memberPlumbing/hid/DoorController.py
View File

@ -124,9 +124,13 @@ class DoorController:
params={"XML": prefix + xml},
auth=requests.auth.HTTPDigestAuth(self.username, self.password),
)
resp_xml = etree.XML(r.content)
if r.status_code != 200:
raise RemoteError(r)
# probably meed to be more sane about this
if r.status_code != 200 or len(resp_xml.findall("{*}Error")) > 0:
resp_xml = etree.XML(r.content)
if len(resp_xml.findall("{*}Error")) > 0:
raise RemoteError(r)
return resp_xml