Handle Byte Order Mark (BOM) in CSVs

memberPlumbing/MembershipWorks.py

@@ -197,6 +197,10 @@ class MembershipWorks:
         )
         if r.status_code != 200:
             raise MembershipWorksRemoteError("csv generation", r)
+
+        if r.text[0] == "\ufeff":
+            r.encoding = r.encoding + "-sig"
+
         return list(csv.DictReader(StringIO(r.text)))
 
     def get_transactions(self, start_date, end_date, json=False):
@@ -210,7 +214,7 @@ class MembershipWorks:
         r = self._get_v1(
             BASE_URL + "/v1/csv",
             params={
-                "crm": "12,13,14,18,19",  # transaction types, see CRM
+                "crm": ",".join(str(k) for k in CRM.keys()),
                 **({"txl": ""} if json else {}),
                 "sdp": start_date.strftime("%s"),
                 "edp": end_date.strftime("%s"),
@@ -221,6 +225,9 @@ class MembershipWorks:
         if json:
             return r.json()
         else:
+            if r.text[0] == "\ufeff":
+                r.encoding = r.encoding + "-sig"
+
             return list(csv.DictReader(StringIO(r.text)))
 
     def get_all_members(self):

pyproject.toml

@@ -17,16 +17,16 @@ authors = ["Adam Goldsmith <adam@adamgoldsmith.name>"]
 [tool.poetry.dependencies]
 python = "^3.7"
 requests = "^2.23.0"
-"ruamel.yaml" = "^0.16.10"
+"ruamel.yaml" = "^0.17.20"
 bitstring = "^3.1.6"
 lxml = "^4.5.0"
 peewee = "^3.13.2"
-mysqlclient = "^1.4.6"
-udm-rest-client = "^0.4.0"
+mysqlclient = "^2.1.0"
+udm-rest-client = "^1.0.6"
 
 [tool.poetry.dev-dependencies]
-black = "^19.10b0"
-isort = "^4.3.21"
+black = "^22.3.0"
+isort = "^5.10.1"
 
 [tool.poetry.scripts]
 doorUpdater = 'memberPlumbing.doorUpdater:main'